opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
175 stars 43 forks source link

Some more linting #275

Closed Peque closed 6 years ago

Peque commented 6 years ago

Fixes #237.

codecov[bot] commented 6 years ago

Codecov Report

Merging #275 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          26       26           
  Lines        3542     3542           
  Branches      256      256           
=======================================
  Hits         3512     3512           
  Misses         18       18           
  Partials       12       12
Impacted Files Coverage Δ
...ain/tests/test_agent_sync_publications_handlers.py 98.27% <100%> (ø) :arrow_up:
osbrain/tests/test_address.py 100% <100%> (ø) :arrow_up:
osbrain/tests/test_common.py 100% <100%> (ø) :arrow_up:
osbrain/proxy.py 100% <100%> (ø) :arrow_up:
osbrain/tests/test_agent_sync_publications.py 100% <100%> (ø) :arrow_up:
osbrain/tests/test_proxy.py 100% <100%> (ø) :arrow_up:
osbrain/tests/test_agent.py 100% <100%> (ø) :arrow_up:
...sbrain/tests/test_agent_async_requests_handlers.py 96% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de2565a...101bce9. Read the comment docs.

ocaballeror commented 6 years ago

The linting and docs checks are not run on appveyor. Are you aware of that?

Peque commented 6 years ago

Yeah, and they are only run once now, rather than once for each Python version. Linting is expected to give the same results for any Python version and for the documentation generation we do not really need to support all Python versions (although they should be supported anyway unless something is broken on Sphinx end).

Thought it was a good idea to separate them. Easier to see if your tests are failing due to styling/linting or due to incompatibilities with a Python version or due to broken tests.