opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
176 stars 43 forks source link

Uncovered lines #279

Closed Peque closed 6 years ago

Peque commented 6 years ago

This exception handling in osbrain/proxy.py is not always covered by the test suite:

class Proxy():
    def shutdown(self, timeout=10.):
        # ...
        except ConnectionClosedError:
            pass

We should create a test that forces a ConnnectionClosedError on shutdown.

Peque commented 6 years ago

Worst thing is not that those lines are not covered, but that they are randomly covered by our test suite. This can lead to unwanted failing coverage reports.