search

opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
175 stars 43 forks source link

Ignore async replies after maximum wait #281

Closed ocaballeror closed 6 years ago

ocaballeror commented 6 years ago

Fixes #280

codecov[bot] commented 6 years ago

Codecov Report

Merging #281 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   99.15%   99.15%   +<.01%     
==========================================
  Files          26       26              
  Lines        3546     3550       +4     
  Branches      256      256              
==========================================
+ Hits         3516     3520       +4     
  Misses         18       18              
  Partials       12       12
Impacted Files Coverage Δ
osbrain/tests/test_agent_async_requests.py 100% <100%> (ø) :arrow_up:
osbrain/agent.py 97.71% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bcc4d0a...d6007b2. Read the comment docs.

ocaballeror commented 6 years ago

@Peque you're right. The code was actually wrong, since del was not being called with the default on_error :sweat_smile:

Peque commented 6 years ago

@ocaballeror I think I commented on an outdated commit in my last review, but the comment still applies. :sweat_smile: