opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
175 stars 43 forks source link

Safety #294

Closed Peque closed 6 years ago

Peque commented 6 years ago

Fixes #287.

Not really proud about the final result, but should definitely be a step forward...

codecov[bot] commented 6 years ago

Codecov Report

Merging #294 into master will increase coverage by 0.14%. The diff coverage is 96.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage    99.1%   99.24%   +0.14%     
==========================================
  Files          26       26              
  Lines        3557     3588      +31     
  Branches      258      257       -1     
==========================================
+ Hits         3525     3561      +36     
+ Misses         19       15       -4     
+ Partials       13       12       -1
Impacted Files Coverage Δ
osbrain/tests/test_nameserver.py 98.11% <100%> (ø) :arrow_up:
osbrain/tests/test_agent.py 100% <100%> (ø) :arrow_up:
osbrain/agent.py 98.14% <95.55%> (+0.43%) :arrow_up:
osbrain/tests/test_bugs.py 100% <0%> (+16.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cffe79b...049f7d9. Read the comment docs.

ocaballeror commented 6 years ago

Maybe merge #296 first? That way we can merge this with the tests passing.

Peque commented 6 years ago

@ocaballeror Rebased, squashed and added socket close with linger tests.

Peque commented 6 years ago

Also pushed a new commit to fix: https://travis-ci.org/opensistemas-hub/osbrain/jobs/364043140

I looked for other possible occurrences in our test suite and that seems to be the last one.