opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
176 stars 43 forks source link

Fixed code example typo - renamed param name 'handlers' to 'handler' #298

Closed ileacristian closed 6 years ago

ileacristian commented 6 years ago

Fixed a typo in a code example. The old code would throw a runtime exception: ERROR [2018-04-22 23:55:28.625972] (Bob): An exception occurred while running! (subscribe() got an unexpected keyword argument 'handlers')

codecov[bot] commented 6 years ago

Codecov Report

Merging #298 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          26       26           
  Lines        3588     3588           
  Branches      257      257           
=======================================
  Hits         3561     3561           
  Misses         15       15           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05a89c9...f456f4e. Read the comment docs.

Peque commented 6 years ago

Woops... Nice catch! :blush:

Would you mind renaming the commit message to:

Fix example with wrong `handler` parameter name

?

I can do that for you if you want. :+1:

Peque commented 6 years ago

@ileacristian Thanks a lot! :smile: