opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
175 stars 43 forks source link

Avoid using version 17 of PyZMQ for now #302

Closed Peque closed 6 years ago

Peque commented 6 years ago

See https://github.com/zeromq/pyzmq/issues/1170.

The test suite breaks with PyZMQ v17 while passes when pyzmq is set to <v17 (v16).

codecov[bot] commented 6 years ago

Codecov Report

Merging #302 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   99.24%   99.19%   -0.06%     
==========================================
  Files          26       26              
  Lines        3588     3588              
  Branches      257      257              
==========================================
- Hits         3561     3559       -2     
- Misses         15       16       +1     
- Partials       12       13       +1
Impacted Files Coverage Δ
osbrain/__init__.py 100% <100%> (ø) :arrow_up:
osbrain/tests/test_bugs.py 83.33% <0%> (-16.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f456f4e...781e26d. Read the comment docs.

ocaballeror commented 6 years ago

303

Everything titled "for now" probably needs a new issue, so it doesn't become "for ever".

Peque commented 6 years ago

@ocaballeror I'd say "surely" instead of "probably". :stuck_out_tongue_winking_eye: