opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
175 stars 43 forks source link

Fix PyZMQ 17 compatibility issues #307

Closed Peque closed 6 years ago

Peque commented 6 years ago

By manually cleaning IPC files after closing sockets.

Fixes #303. Closes #305.

codecov[bot] commented 6 years ago

Codecov Report

Merging #307 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   99.24%   99.19%   -0.06%     
==========================================
  Files          26       26              
  Lines        3588     3601      +13     
  Branches      257      261       +4     
==========================================
+ Hits         3561     3572      +11     
- Misses         15       16       +1     
- Partials       12       13       +1
Impacted Files Coverage Δ
osbrain/agent.py 98.17% <100%> (+0.03%) :arrow_up:
osbrain/tests/test_bugs.py 83.33% <0%> (-16.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d466893...0c5828a. Read the comment docs.

ocaballeror commented 6 years ago

Is this not the same as #305 ?

Peque commented 6 years ago

@ocaballeror Almost. Only we unlink from the binder only and we make sure we close all sockets in a channel. I do not mind implementing this over #305 if you think it is better (to keep @minrk's contribution in the history).

ocaballeror commented 6 years ago

Yeah, I would prefer that if it isn't too much trouble. After all it was him who fixed it, so he deserves his place in the commit history in my opinion :smile:

Peque commented 6 years ago

@ocaballeror Yeah, did not want to bother him with rebasing, squashing or commit message style rules, but I guess we can be more lenient when accepting external/occasional contributions. :blush:

I'll do the rebase/squash/rename while keeping his authorship and then add the current changes as a "refactor". :+1:

Peque commented 6 years ago

@ocaballeror Done.