search

opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
175 stars 43 forks source link

Fix linting errors #315

Closed ocaballeror closed 5 years ago

ocaballeror commented 5 years ago

Flake8 was updated and a bunch of new errors started showing up: https://travis-ci.org/opensistemas-hub/osbrain/jobs/452151480

Apparently we weren't using noqa correctly either. flake8: noqa would ignore warnings for the entire file, regardless of whether we used them in a single line or not. This behavior has been changed in the new version, and that uncovered a couple more errors.

Peque commented 5 years ago

Looks good to me. :+1:

codecov[bot] commented 5 years ago

Codecov Report

Merging #315 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          26       26           
  Lines        3602     3602           
  Branches      261      261           
=======================================
  Hits         3575     3575           
  Misses         15       15           
  Partials       12       12
Impacted Files Coverage Δ
osbrain/tests/test_logging.py 100% <100%> (ø) :arrow_up:
osbrain/proxy.py 100% <100%> (ø) :arrow_up:
osbrain/agent.py 98.17% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05e06f6...5c1c4b0. Read the comment docs.