opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python

https://osbrain.readthedocs.io/en/stable/

Apache License 2.0

175 stars 43 forks source link

Fix linting errors #320

Closed ocaballeror closed 5 years ago

ocaballeror commented 5 years ago

Two things:

pep8-naming was updated and now flake8 (sadly) works as expected, which means it doesn't support using a single noqa to ignore the entire function definition. Now you need separate comments for every affected line. I opened an issue but they told me they're not going to implement it and closed it immediately.
The per-file-ignores plugin was integrated into flake8 and it's not necessary anymore.

ocaballeror commented 5 years ago

Also, congrats on reaching 100 stars 🎉 🎉

codecov[bot] commented 5 years ago

Codecov Report

Merging #320 into master will decrease coverage by 0.13%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   99.25%   99.11%   -0.14%     
==========================================
  Files          26       26              
  Lines        3602     3602              
  Branches      261      261              
==========================================
- Hits         3575     3570       -5     
- Misses         15       18       +3     
- Partials       12       14       +2

Impacted Files	Coverage Δ
osbrain/proxy.py	`100% <100%> (ø)`	:arrow_up:
osbrain/__init__.py	`91.66% <0%> (-8.34%)`	:arrow_down:
osbrain/tests/test_agent_transport.py	`94.04% <0%> (-2.39%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0344cb3...1f9534d. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #320 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          26       26           
  Lines        3602     3602           
  Branches      261      261           
=======================================
  Hits         3575     3575           
  Misses         15       15           
  Partials       12       12

Impacted Files	Coverage Δ
osbrain/proxy.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0344cb3...1f9534d. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #320 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          26       26           
  Lines        3602     3602           
  Branches      261      261           
=======================================
  Hits         3575     3575           
  Misses         15       15           
  Partials       12       12

Impacted Files	Coverage Δ
osbrain/proxy.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0344cb3...1f9534d. Read the comment docs.