opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python

https://osbrain.readthedocs.io/en/stable/

Apache License 2.0

175 stars 43 forks source link

Lower default log level in agent info messages #328

Closed Peque closed 5 years ago

Peque commented 5 years ago

@ocaballeror I think you once suggested this. It is time now! :stuck_out_tongue_winking_eye:

Fixes https://github.com/opensistemas-hub/osbrain/issues/329

codecov[bot] commented 5 years ago

Codecov Report

Merging #328 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          25       25           
  Lines        3566     3566           
  Branches      257      257           
=======================================
  Hits         3540     3540           
  Misses         14       14           
  Partials       12       12

Impacted Files	Coverage Δ
osbrain/agent.py	`98.17% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3685ab5...dfb4732. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #328 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          25       25           
  Lines        3566     3566           
  Branches      257      257           
=======================================
  Hits         3540     3540           
  Misses         14       14           
  Partials       12       12

Impacted Files	Coverage Δ
osbrain/agent.py	`98.17% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3685ab5...dfb4732. Read the comment docs.

ocaballeror commented 5 years ago

Did I? Well, then I agree with 8-months-ago me.

What about the environmental variable, though ? I think that would be interesting from an end user's perspective. OSBRAIN_DEBUG maybe?

Peque commented 5 years ago

@ocaballeror Yeah, that is a different issue. I just created https://github.com/opensistemas-hub/osbrain/issues/329 to differentiate them.

This PR will only close https://github.com/opensistemas-hub/osbrain/issues/329. Adding a variable to configure logging level would still be a wanted feature.