opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python

https://osbrain.readthedocs.io/en/stable/

Apache License 2.0

175 stars 43 forks source link

Imporving `basic_patterns.rst` documentation file #348

Closed RezaBehzadpour closed 4 years ago

RezaBehzadpour commented 4 years ago

A couple of improvements in the basic_patterns.rst documentation file.

codecov[bot] commented 4 years ago

Codecov Report

Merging #348 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          26       26           
  Lines        3573     3573           
  Branches      259      259           
=======================================
  Hits         3546     3546           
  Misses         14       14           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b7061b...5b52ca7. Read the comment docs.

RezaBehzadpour commented 4 years ago

Yes, why not.

Peque commented 4 years ago

Merged: https://github.com/opensistemas-hub/osbrain/commit/c06bec2c4d5d66801830f530615d540717abee30

Thanks for the contribution! :blush:

Next time, please, configure your email in Git appropriately, to avoid having an ugly email address like 29193529+RezaBehzadpour@users.noreply.github.com. :stuck_out_tongue_winking_eye:

RezaBehzadpour commented 4 years ago

Thanks man. I'll make sure that next time my Git is configured properly. 😇🙏
Why did you close the PR? Isn't it ready to be merged or you want to merge it in future time? Cause I can't see any changes in the documentation!

Peque commented 4 years ago

The pull request is already merged, see: https://github.com/opensistemas-hub/osbrain/commit/c06bec2c4d5d66801830f530615d540717abee30

I simply squashed the two commits you made and changed the commit subject. You keep the authorship. :blush:

Thanks for reporting that the changes were not displayed in the documentation. It seems Read the Docs was misconfigured. I fixed that and you should now be able to see your changes in the latest version of the documentation. It will be included in stable once we roll out the next release (no ETA for that).

RezaBehzadpour commented 4 years ago

Thanks for your kindness when responding to my comments. 😇🌹🌻 Wish you the best. 👑