Parameters address in send() and recv() should be renamed.
Parameter alias should hint at the socket function. Various functions accept alias as the parameter, but it has VERY different use.
Explanation:
osbrain follows the standard where alias refers to the alias of the socket.
On the server-side:
bind() - great, follows the standard Linux implementation. alias refers to the server socket used for handling connections
Newly created sockets for read/write are omitted (great), user doesn't have to be exposed to what accept() normally does
On the client-side:
connect() - okay, parameter alias refers to the socket of the client, parameter server- address the server is bound to. I think alias should be mandatory.
send() - standard is broken. address refers to the socket of the client (and that in itself is good, as per the standard low-level implementations).
addressinsend()andrecv()should be renamed.aliasshould hint at the socket function. Various functions accept alias as the parameter, but it has VERY different use.Explanation: osbrain follows the standard where
aliasrefers to the alias of the socket. On the server-side:bind()- great, follows the standard Linux implementation.aliasrefers to the server socket used for handling connections Newly created sockets for read/write are omitted (great), user doesn't have to be exposed to what accept() normally doesOn the client-side:
connect()- okay, parameter alias refers to the socket of the client, parameterserver- address the server is bound to. I thinkaliasshould be mandatory.send()- standard is broken. address refers to the socket of the client (and that in itself is good, as per the standard low-level implementations).recv()- standard is broken again.