openskope / skope-interface

The new SKOPE web portal interface.
https://www.openskope.org
4 stars 2 forks source link

Don’t default to computing a graph for the whole area if no area is selected. #153

Closed jterstriep closed 6 years ago

jterstriep commented 6 years ago

Interestingly, someone else suggested defaulting to the whole area. This could be problematic for large areas but we should be able to provide values calculated with the data is loaded.

Zodiase commented 6 years ago

A workaround is to pre-calculate the results for the whole area.

The behavior this issue is targeting is the result from the "continuity" feature where the "focus boundary", as I call it, is carried over from discover tab to map view tab and then graph view tab. To be accurate, it's not selecting the whole area by default; if you open the workspace page without the "focus boundary" parameter, the graph view tab won't have a "focus boundary" thus won't load anything. But if you do specify a boundary in the discover tab and then head to the graph view, the boundary will get carried over per the "continuity" feature specification.

kintigh commented 6 years ago

I think we decided this was not an issue as if there is no are selected, it doesn't try to compute the graph. however, we need to change the label to "...select a point or area..."

Zodiase commented 6 years ago

Closed because this is the current behavior. (That is unless an area is selected due to continuity)