openskope / skope-interface

The new SKOPE web portal interface.
https://www.openskope.org
4 stars 2 forks source link

Incorrect button coloring on map selection tools. #190

Closed Zodiase closed 6 years ago

Zodiase commented 6 years ago

From @kintigh: On Map selection the Hand and Draw a rectangle selection are colored exactly opposite of what I would expect. It seems to me the active one should be the white, that is highlighted, one and the gray ones not selected.

Zodiase commented 6 years ago

image

@kintigh These buttons are a group of toggle buttons, where the active one among the group should look like it's been pressed down. Here are a few examples:

From Microsoft Word: image

From Google Docs: image

From Material Design: image

From Bootstrap: image

The library I'm using doesn't provide an out-of-box solution for this type of buttons so I improvised a bit to make the active one have a darker background. I can try to make it more obvious that it's "pressed down".

kintigh commented 6 years ago

Yes I think having it something other than the background color would do it. Thanks. Keith

Zodiase commented 6 years ago

Now the selected has a stronger border in addition to a darker background. The non-selected ones have a weaker color for the icon. The shadows are removed all-together to avoid being mis-interpreted as an indication of selection.

image