search

openskope / skope-interface

The new SKOPE web portal interface.
https://www.openskope.org
4 stars 2 forks source link

Contact link doesn't work. #195

Closed jterstriep closed 6 years ago

jterstriep commented 6 years ago

Keith report that "Contact option still does not work for me in Chrom/Win10/Outlook"

This is something that difficult to test because users can have all kinds of different systems. Do we have a sense of that will work? Is there any way to have a fallback?

kintigh commented 6 years ago

It now pops up an Outlook window but the to: address is mailto://kintigh@asu.edu (invalid) instead of kintigh@asu.edu. The Subject is &body= instead of some text.

jterstriep commented 6 years ago

Thanks. I misunderstood the configuration. I'll fix that.

Zodiase commented 6 years ago

Should be fixed by now.

Zodiase commented 6 years ago

@jterstriep I assume you reopened this because Keith wants a subject (even though it's not exactly what this issue is about)?

@kintigh What do you think would be a good subject?

kintigh commented 6 years ago

SKOPE App Query/Comment

Zodiase commented 6 years ago

@jterstriep The above commit adds the subject field. Are there anything else left for this issue?

kintigh commented 6 years ago

No, nothing more. It is not showing now, but I assume the commit hasn't been done.

Zodiase commented 6 years ago

@kintigh The highlighted text shows a commit referencing this issue. It contains changes that should resolve the empty subject issue.

image

These commits will trigger DockerHub to build new images of this app (with the latest code at the time of commit) and tag the image with latest. When the building is done, Jeff's script can then pull the latest image to staging, after which you would be able to see the changes from these commits revealed. DockerHub is a free service so they really take their time doing the builds. From my observation a single build would take anywhere from 30 to 60 minutes, obviously depending on how busy their servers are. They also enforce delays in-between builds so, for example, two consecutive triggers would likely cause the last build to finish in 150 minutes or more. So I try to push changes less frequently to avoid clogging the build pipeline with too many unnecessary builds.

Anyone can check the automated build status here: https://hub.docker.com/r/openskope/webapp/builds/

On the other hand, I'm also doing manual builds on my computer for each of the new versions, mainly because in some cases it could be faster than DockerHub and so you'd be able to see the results faster. However while it's building I basically can't do much else on my computer so I can't do it for every commit. I try to batch the commits into reasonable chunks and then bump the version and then do a manual build of that new version.

Either way it takes a bit of time until the changes can be reflected on the staging server.

Zodiase commented 6 years ago

Anyway the change should be reflected in version 0.1.20, if not earlier (from the automated builds).