Closed Niall7459 closed 2 years ago
thanks for your suggestion, the extensive input and sorry for the late response. TIS-B support would be nice indeed!
On my local copy I have rearranged the decoder to decode TIS-B and ADS-R as ADS-B messages. I can push the changes. Not sure if there is any thing else that should be added for this
My other question.. are you open for structural changes/cleanup? Checking to ensure so I don't end up breaking any existing integration in OpenSky's infrastructure.
On my local copy I have rearranged the decoder to decode TIS-B and ADS-R as ADS-B messages. I can push the changes. Not sure if there is any thing else that should be added for this
The standard required for TIS-B seems to be ICAO Doc 9871. Did you implement it following the standards document?
are you open for structural changes/cleanup?
Sure. Do you have specific recommendations?
I've followed RTCA DO-282B. You may want to double check it conforms when I PR. Decoding for each of the message types is exactly the same.
I'll comment according to RTCA DO-282B within the code
As for cleaning up, just following standard naming conventions, e.g Renaming subtype to SubType e.g
My other question: will the BDS branch be merged? Is it not fully functional yet? I might give this a try locally
I've followed RTCA DO-282B. You may want to double check it conforms when I PR. Decoding for each of the message types is exactly the same.
That's great
My other question: will the BDS branch be merged? Is it not fully functional yet? I might give this a try locally
Not very soon. It still needs some integration work and interface clean-up. Probably something for release 4.0.0
I would definitely like this feature added, particularly for decoding MLAT data.
I'm still largely an amateur at this so I don't want to rush into making a pull request with my limited understanding of Mode S.
However for my own purposes I have simply modified the software so that in the Mode S Decoder, downlink format 18 and first field 2 is accepted as an understood ES message. (It currently only accepts first field values < 2 for downlink format 18.) This is sufficient for the software to handle MLAT messages that I receive from the server as standard ADS-B position & velocity messages.
It's now implemented in this fork: https://github.com/SeRoSystems/lib1090
Introduction TIS-B and ADS-R are not currently implemented in Java-ADSB. It would be neat generally to have this functionality. Building on that, Java-ADSB is unable to decode MLAT messages produced by https://github.com/mutability/mlat-client that use these formats.
Source code behind the mlat-client synthetic extended squitter is here: https://github.com/mutability/mlat-client/blob/master/mlat/client/synthetic_es.py
More information on TIS-B implementation at Table A-29 of RTCA DO-260 "Minimum Operational Performance Standards (MOPS) for 1090ES". I am unsure wether Annex 10 - Aeronautical Telecommunications - Volume IV- Surveillance Radar and Collision Avoidance Systems (Amendment no. 90 effective 16/7/18) covers TIS-B
Although I'm sure your totally aware of it, I have a couple hex dump examples of these messages below:
This link may also be useful: https://github.com/Mictronics/readsb/blob/e622f703d5a9d8c95561ae379abaef2449bdebb2/mode_s.c#L1379
Additional Information Applications currently would not be able determine how the message was received,
ModeSReply#getSource()
could be introduced to return the source type:Look forward to hearing your response