openskynetwork / opensky-api

Python and Java bindings for the OpenSky Network REST API
GNU General Public License v3.0
345 stars 126 forks source link

[Python] Add new request types available in the OpenSky REST API. #53

Closed marataj closed 1 year ago

marataj commented 1 year ago

I recently found the OpenSky service, and it's great! I used it in my private data analysis projects. So far I have mainly worked with the REST API, but decided to adapt the python library to all request types that were needed. During the work, the code has been tested on Python 3.10 and 2.7 to keep compatibility, as assumed. I'm happy to contribute to this project!

The scope of changes is the extension of the OpenSkyApi class with additional methods, that cover all types of requests available in the OpenSky REST API.

jaluebbe commented 1 year ago

To clarify how to use your new class/methods, you may create the documentation for https://openskynetwork.github.io/opensky-api/python.html by editing https://github.com/openskynetwork/opensky-api/blob/master/docs/free/python.rst .

marataj commented 1 year ago

To clarify how to use your new class/methods, you may create the documentation for https://openskynetwork.github.io/opensky-api/python.html by editing https://github.com/openskynetwork/opensky-api/blob/master/docs/free/python.rst .

Done.

jaluebbe commented 1 year ago

I looked into the documentation. It looks great. However, it is not clear where the user credentials are required and where not. Compare to the example for my states "api = OpenSkyApi(USERNAME, PASSWORD)".

jaluebbe commented 1 year ago

all tests passed on my machine.