search

openslice / io.openslice.main

Main parent project
Apache License 2.0
5 stars 5 forks source link

Updated deploy-develop.sh to support Java 17 #18

Closed rafael-direito closed 1 year ago

rafael-direito commented 1 year ago

Previously, the deployment script relied on a maven:3.8.2-adoptopenjdk-15-openj9 docker image to build and package all services. With the upgrade to Java 17, the deployment script is unable to build the JARs. Thus, this update, which updates the docker image to maven:3.8.3-openjdk-17.

ctranoris commented 1 year ago

hm that's rather old. Please check the develop branch, deploy-develop.sh is no longer needed. just deploy.sh script with passing parameter the brnach

rafael-direito commented 1 year ago

You are right. I was still using the deploy-develop.sh. Maybe we can remove it if it's not being used anymore (and reflect this update on the documentation)... ?

ctranoris commented 1 year ago

In the https://github.com/openslice/io.openslice.main/tree/develop/compose is not there. The documentation in the development branch is somehow updated... We hope to merge it soon with master in all projects to close a kind of release and then start new with ETSI

rafael-direito commented 1 year ago

The develop branch's documentation states that the deployment script should be downloaded with the following: wget https://raw.githubusercontent.com/openslice/io.openslice.main/master/compose/deploy.sh. Please notice the .../master/.... See image below:

Screenshot 2023-09-26 at 14 15 33

Maybe we should update the documentation to use the develop branch to download the script. Just to keep everything consistent.

ctranoris commented 1 year ago

huh sure cc @kostistr

kostistr commented 1 year ago

The documentation referring to a contributor is under /contributing/developing/ tab. There, as @rafael-direito correctly mentioned the deploy.sh should be downloaded, and it is, from the develop branch (/develop/compose/deploy.sh).

The /deployment/ tab of the documentation is referring to a deployer, regardless of its desire to deploy master or develop branch. Thus I propose to keep the download of the deploy from the master branch which will be considered the stable one.

Right now, it is not working as it should for the reason @rafael-direito mentioned, but after the imminent merge of the develop branch to master, the documentation will be aligned to the committed files. The relevant issue tracking documentation problems is https://github.com/openslice/io.openslice.main/issues/15.

kostistr commented 1 year ago

Closing the MR without merging, due to the last comment.