Remove unnecessary unpacking

openslide / openslide-python

Python bindings to OpenSlide

https://openslide.org/

GNU Lesser General Public License v2.1

374 stars 183 forks source link

Remove unnecessary unpacking #276

Closed dandyrilla closed 2 months ago

dandyrilla commented 2 months ago

Hi, I am a user who really enjoys and actively utilizes OpenSlide. I would like to express my gratitude to @bgilbert for creating such an excellent open-source project!

What is this PR?

While using the code, I found a small area where I could contribute, so I created a PR with a one-line change. Since the max() function can accept iterable objects such as generators, it seems that there is no need to unpack them using an asterisk *.

Changes

Refactor code by removing unnecessary unpack operator *

openslide-bot commented 2 months ago

DCO signed off :heavy_check_mark:

All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1.

dandyrilla commented 2 months ago

Sorry for force-pushing many commits. I amended commits because I was not familiar with DCO check. Now this PR passes the check.

bgilbert commented 2 months ago

Looks good, thanks for the cleanup!