search

opensmarthouse / opensmarthouse-core

Eclipse Public License 2.0
7 stars 0 forks source link

Remove assembly from core repository #2

Closed cdjackson closed 4 years ago

cdjackson commented 4 years ago

@splatch please merge this if you're happy to delete this - I think the best place for this is as the separate repository as the UI is nearly always needed to get a working system...

Signed-off-by: Chris Jackson chris@cd-jackson.com

splatch commented 4 years ago

Hey Chris, It is rather straight change, only one question is what we do with common assembly resources located in framework. Their primary use is in assembly hence keeping both close to each other would make some sense. On other hand making it available in core lets others utilize "shared" scripts with just one version placeholder at the cost of split brain for us.

cdjackson commented 4 years ago

I'm not against leaving the assembly in, however I personally find it not very useful as you nearly always need the UI. This is why I was thinking to remove the assembly from the core, and have the separate assembly repository to consolidate the core and webui.

Aren't all the scripts that you talk about in the framework module - we're not removing any of that. Or am I (probably ;) ) missing something?

cdjackson commented 4 years ago

Closing this. This is still considered useful for development as a quick route for testing.