search

opensmarthouse / opensmarthouse-core

Eclipse Public License 2.0
7 stars 0 forks source link

Doc updates - Fundamentals & OSGI #3

Closed bwosborne2 closed 3 years ago

bwosborne2 commented 3 years ago

Updated index, Fundamentals, & OSGI

Converted html to md converted openHAB to openSmartHouse fixed broken links

bwosborne2 commented 3 years ago

@cdjackson Please Review

cdjackson commented 3 years ago

Thanks @bwosborne2

5iver commented 3 years ago

@cdjackson, wouldn't it be best to require signed commits?

cdjackson commented 3 years ago

Yes, you are right that we should do this. Given it was “just” the docs that were changed I merged based on the standard “minor change exemption” that is normally applied when people don’t sign PRs. For sure, any significant code changes should be signed.

I’m happy though if you wanted to set up a check for this on the repo - I guess there’s a GitHub action or plugin to check this, but I’ve just not looked...

bwosborne2 commented 3 years ago

Like I mentioned in the forum this is my first PR. There is more documentation work to be done.

I usually say I am slow but educable.

cdjackson commented 3 years ago

It was in no way a criticism Bruce - I probably should have pointed it out, but it’s not really a problem at all at this stage, but certainly something for further improvement within the project.

bwosborne2 commented 3 years ago

No worries. There are more changes needed. Should I wait on a PR?

I just seem to have "butted heads" with Scott the past couple of days. 😢

cdjackson commented 3 years ago

No need to wait. CI is failing at the moment, but ignore that. Signing of commits is simply a case of adding some text to the commit message. Just do a quick search for "signing github commits" or something like that.