search

opensmarthouse / opensmarthouse-web

Provides public elements of OpenSmartHouse web site including ZWave database import/export and log file processors.
0 stars 2 forks source link

[zwavedatabase] "Show Diff" is broken. #35

Closed bwosborne2 closed 3 years ago

bwosborne2 commented 3 years ago

The "Show Diff" function, at tines, gives totally inaccurate data. This is used extensively when reviewing items. Device 1074 is one obvious example. the device was last approved on 2021-01-16 but then subsequently modified. The diff shows it was created from new.

image

image

This is wrapped in the dmx code somewhere so I am inable to assist. Until this is resolved I will refrain from approving anu database Items I did not modify. Once already I depended on the diff and made a ticket only to have to backtrack when the user corrected me.

bwosborne2 commented 3 years ago

Further research. Looking at the zwave_devices table, approved_export column is null even though it was approved & exported on 2021-01-16 09:19:23. That may point to an approval / export issue

bwosborne2 commented 3 years ago

When a device is approved, approved data and export date are both set. i thought it strange they looked the same. Also forst approval data appears empty and does not seem to be referenced in the approval script.

cdjackson commented 3 years ago

This was fixed quite a while ago.