search

opensmarthouse / opensmarthouse-web

Provides public elements of OpenSmartHouse web site including ZWave database import/export and log file processors.
0 stars 2 forks source link

Update channels php files #45

Open apella12 opened 1 year ago

apella12 commented 1 year ago

Added alarm_cold & alarm_humidity to align with merged PR. Also because file did not match the current dropdown, added or deleted channels to match. Left channels with no match in the binding alone for now.

cdjackson commented 1 year ago

Thanks. This is not in any way hooked up to the website version which has changed considerably over the years. I will need to find some time to try and reconcile this.

bwosborne2 commented 1 year ago

I thought this project died a while ago.

cdjackson commented 1 year ago

Not at all. This is used by openhab for starters, and also other OSH users.

apella12 commented 1 year ago

I suspected a disconnect when the dropdown (Endpoint:Channel) while creating a device did not match the github file. I know you are busy. All I really need is alarm_cold & alarm_humidity to be added to the dropdown. They are part of the binding (alarmConverter) since PR #1850, but are not available for use when creating a device. The other changes I made were just for consistency. Typical type A behavior ;-)

cdjackson commented 1 year ago

Ok, thanks for looking at this. As a suggestion, how about I update master branch with what's actually on the website, and then you rebase this (if needed) on that. I think that's best as we then get back in sync - sorry - it's a bit more work for you (maybe).

apella12 commented 1 year ago

No problem with your suggestion. I don't think it will be that difficult. I have already compared the channels in the dropdown that appears when creating the device a couple of times. Worst case I'll delete the fork (and the PRs) and start over (but I have saved my edits outside github). I can fix the logviewer too if you update that file also.