The getSerialNumber() method should return either a discrete value or else null, rather than returning the string "(not implemented)".
This impacts downstream consumers of OSS_SNMP, because it means that the only way to check if there's no serial number is to run a string match against "(not implemented)" rather than the more obvious isset().
The
getSerialNumber()method should return either a discrete value or elsenull, rather than returning the string"(not implemented)".This impacts downstream consumers of OSS_SNMP, because it means that the only way to check if there's no serial number is to run a string match against
"(not implemented)"rather than the more obviousisset().