search

opensouls / terminal-copilot

A smart terminal assistant that helps you find the right command.
Apache License 2.0
573 stars 43 forks source link

Windows Issue #17

Closed igorpereirabr1 closed 1 year ago

igorpereirabr1 commented 1 year ago

Looks like the dependency of simple-term-menu package makes impossible to use this in Windows: https://github.com/IngoMeyer441/simple-term-menu/issues/71

Traceback (most recent call last): File "C:\Users\ju195\Anaconda3\lib\runpy.py", line 197, in _run_module_as_main return _run_code(code, main_globals, None, File "C:\Users\ju195\Anaconda3\lib\runpy.py", line 87, in _run_code exec(code, run_globals) File "C:\Users\ju195\Anaconda3\Scripts\copilot.exe__main__.py", line 4, in
File "C:\Users\ju195\Anaconda3\lib\site-packages\copilot\copilot.py", line 8, in from simple_term_menu import TerminalMenu File "C:\Users\ju195\Anaconda3\lib\site-packages\simple_term_menu.py", line 39, in raise NotImplementedError('"{}" is currently not supported.'.format(platform.system())) from e NotImplementedError: "Windows" is currently not supported.

github-actions[bot] commented 1 year ago

Message that will be displayed on users' first issue

JoelKronander commented 1 year ago

Ah thanks for noting that.

Would you be up for making a pr that detects if the user runs windows and does a different import/type of menu selection? I don't have a windows machine so hard to test for me.

JoelKronander commented 1 year ago

Fixed by @EdwardTheLegend! ❤️ Let us know if something still don't work as expected on Windows.