opensource-construction / website

os.c website, content and design components
https://opensource.construction
MIT License
3 stars 4 forks source link

added a training section to the website #17

Closed ocni-dtu closed 4 months ago

ocni-dtu commented 4 months ago

@n0rdlicht could you please give some feedback?

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opensource-construction ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:02pm
n0rdlicht commented 4 months ago

@ocni-dtu many thanks for the PR - looks good on first glance. Will need to check it tomorrow however - sorry for the slight delay. Getting back to all things website tomorrow.

n0rdlicht commented 4 months ago

@ocni-dtu had the chance to do a local check and only one minor thing popped up:

What's your take on the following:

I agree, that having dedicated "landing"/"listing" pages (like /trainings) makes sense for new content types - the old layout only had sections listing them on the main page directly linking to individual content pages. But thinking that can be the second step, e.g. we start with a subpage for a new content type and "promote" it to a section on the home page once we flesh out content. Wdyt? Hence, will work a bit on those landing pages after merging this. Your draft is pretty much what we need for those I think, but maybe worth adding an events and projects one as well.

Todo (besides other layout fixes) on my end: