search

opensource-nepal / go-nepali

go-nepali is a go package containing features that will be useful for Nepali projects.
GNU General Public License v3.0
7 stars 5 forks source link

Remove absolute imports #4

Closed aj3sh closed 1 year ago

aj3sh commented 1 year ago

Remove the absolute imports from the source code.

Eg: https://github.com/orgs/opensource-nepal/go-nepali/dateConverter

sugat009 commented 1 year ago

After some assessment, I've found that for modules that targeted to be installed in other projects generally have the module name as github.com/<username> which makes them installable. Removing github.com/opensource-nepal from the module name did not cause any issues in the code, however, it made the module uninstallable. Let's not do this for now.

aj3sh commented 1 year ago

Ok sure. Closing this issue then.