Closed golesuman closed 10 months ago
Hello @golesuman , thank you for your contribution.
The tests that you have added might have been misplaced. TestNumber
class is for the tests of the number
package as a whole. We try to make sure that the test classes only test one particular entity, so TestNepaliNumberMethods
class in the same test file might be a better choice to add your tests.
Also, we follow the convention of writing commit messages of the form <type>: <verb> <what was done>
.
For example in your case it might be test: Add object representation and equality tests for nepalinumber
.
@golesuman Can you also squash your commit into one commit?
Closing this stale PR. cc: @sugat009
Description
Add tests with full test coverage
Fixes Issue
64
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
"fix(google): Fixed foobar bug"
,"feat(accounts): Added foobar feature"
.README.md
.CHANGELOG.md
for the significant changes.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.