Fix metrics rendering and adds data tests

ravenac95 commented 3 weeks ago

This is sadly a fairly big change that I found hard to disentangle. I found some strange things with some 2nd order rolling queries that were returning much larger results than expected - I'm hoping fixing this speeds things up. Also I still had some problems with tiny changes causing some fairly massive updates to all models. So to make the metrics factory much easier to maintain this change was necessary.

Highlights:

Adds tests for first, second, and third order metrics.
Improves code organization (ya we should have had this before)
Adds testing for small components of the factory - to ensure correctness throughout.
Introduces (hopefully) some speed improvements

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kariba-network	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 29, 2024 11:23pm
oso-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 29, 2024 11:23pm

oso-prs[bot] commented 3 weeks ago

Test deployment unnecessary, no dbt files have been changed.

opensource-observer / oso

Fix metrics rendering and adds data tests #2426