opensource-observer / oss-directory

A curated directory of open source software (OSS) projects and their associated artifacts
https://www.opensource.observer
Apache License 2.0
51 stars 135 forks source link

run importAgora on existing projects #369

Closed ryscheng closed 5 months ago

ryscheng commented 5 months ago

Okay so this runs importAgora only on the existing projects. Need to review the full diff

oso-prs[bot] commented 5 months ago

Validation Results

⛔ Found 33 errors ⛔

commit a532c6b76d666464ae560a44ce7b9a02933e1b1d


Overview

0x1e9ffaa25d5f8206c697c92bcdee9fa16455cf94

0x95c99ea6d7e72e99f18049019a427a4a17c53a30

0x43e3e4d002ba65c6a26d2e4c998b46e427370e6c

0xe5cc6f5bbb3eee408a1c022d235e6903656f2509

0x26022d2740cf222805d08e05145c373798f3fbc6

0x48fbf0b7e6bdaa9d7452feb34507b2bddb148e54

0xa7b88a746fa457578d5abd6234471f07d895f46b

0x44df096d2600c6a6db77899db3de3aecff746cb8

0x1b03d75094884714973f22867359de4b81af2f00

0x295e0fc7ab0f86df5597f38c9568a2da217e6673

0x66747bdc903d17c586fa09ee5d6b54cc85bbea45

0xa333e18249d0e31ae6a57c9be6e4cdf5ce0837ec

0xad1613cf70b62c4e1542ae29b3faddfceffbe8fc

0x41d055587ea1b401365757cbbbf9e172483b6dc3

0x381c031baa5995d0cc52386508050ac947780815

0x187a9763fcc7ecffa9bc50b0fe5bbae71cda7b59

0x2cde9919e81b20b4b33dd562a48a84b54c48f00c

0x3466eb008edd8d5052446293d1a7d212cb65c646

0x72f46ffbd3213218137015ebccf70bfaaf619513

0x0e63d6f414b40bafca676810ef1abf05ecc8e459

0x3ed9acaac7bd974eb83a8ea6432a239e3c829d5d

0x9bc9ca7e6a8f013f40617c4585508a988db7c1c7

0x3bc1a0ad72417f2d411118085256fc53cbddd137

ccerv1 commented 5 months ago

Okay so this runs importAgora only on the existing projects. Need to review the full diff

Great, will dig in tomorrow. @ryscheng would it be possible to output the name field in the validator log? That would make it easier to review large, multi-project PRs like this one. Only if it's a super quick addition.

For example:

project_name

0x3bc1a0ad72417f2d411118085256fc53cbddd137

❌ 0x3bc1a0ad72417f2d411118085256fc53cbddd137 is not a deployer on arbitrum_one ❌ 0x3bc1a0ad72417f2d411118085256fc53cbddd137 is not a deployer on optimism ✅ 0x3bc1a0ad72417f2d411118085256fc53cbddd137 is a 'contract' on arbitrum_one ✅ 0x3bc1a0ad72417f2d411118085256fc53cbddd137 is a 'contract' on optimism