opensource-observer / oss-directory

A curated directory of open source software (OSS) projects and their associated artifacts
https://www.opensource.observer
Apache License 2.0
51 stars 135 forks source link

fix: remove multicall and create2 from CMT #401

Closed ccerv1 closed 4 months ago

ccerv1 commented 4 months ago

@akshatmittal I have run some tests on the production data and am now seeing the issue you alerted me to in your initial PR #332

Unfortunately, we won't be able to attribute the downstream impact of these deployments to CMT. The attribution requirements for this round are very strict: all impact goes to the owner of the deployer.

FWIW, this requirement has caused some disappointment with other use cases 😞 (eg, apps that facilitate P2P transactions, interactions with zora factories, etc)

In any case, I have kept the other deployments you included, but removed the multicall and create2 contracts from the CMT project file.

oso-prs[bot] commented 4 months ago

Validation Results

✅ Good to go as long as status checks pass

commit b16722463db08cfa6f690056c8f12d013abe2e6d


Overview

akshatmittal commented 4 months ago

Hey @ccerv1, thanks for alerting me. I was myself trying to figure out how to do this correctly. Would you be open to keeping the create2 factory and removing the multicall address? >98% of all contracts deployed using the factory on Base and Optimism are created by CreateMyToken and I'm not sure how else to attribute impact. I'm not sure how OSO works exactly and I don't know if it'll be able to detect all internal transactions from other proxy contracts to the other listed contracts. (I'd expect to see ~1k contracts, >200k transactions within the period)

What's your best recommendation here?

ccerv1 commented 4 months ago

OK, that seems like the best we can do then. I've added the create2 back and will keep an eye on this. There's another week or so of review, so we can continue to have some back and forth if issues come up :) Appreciate your patience and responsiveness!

akshatmittal commented 4 months ago

Appreciate that, and yes do let me know!