specify encoding, close temporary file handle

opensource-observer / oss-directory

A curated directory of open source software (OSS) projects and their associated artifacts

https://www.opensource.observer

Apache License 2.0

51 stars 135 forks source link

specify encoding, close temporary file handle #442

Closed mseidlx closed 3 months ago

mseidlx commented 3 months ago

small fixes that helped me run the python library more stable on Windows

oso-prs[bot] commented 3 months ago

Validation Results

✅ Good to go as long as status checks pass

commit bb2517ef616668f06a5fb7e09b087954dcc89ffc

Overview

mseidlx commented 3 months ago

hey guys, I just tried the Python library on Python 3.12 on Windows and ran into some smaller issues (UnicodeDecodeError and PermissionError because copied file was still used by another process). The small changes in the PR fixed them for me