[CLOSED] Allow hostname based addresses in peering token

[arturo-aparicio]

Issue by ndhanushkodi Monday Jul 25, 2022 at 03:26 GMT Originally opened as https://github.com/hashicorp/consul/pull/13874

---

When supplying an external address to put into the peering token, the external address could be a hostname of a load balancer, which for example is the default in EKS. We'd want to allow hostname based addresses in the peering token in this case.

I was able to test a hostname based load balancer with this change and it worked as the dialer does not require an IP address.

PR Checklist

• [x] updated test coverage
• [ ] external facing docs updated - docs change for all of the expose servers feature to come in future
• [x] not a security concern

---

ndhanushkodi included the following code: https://github.com/hashicorp/consul/pull/13874/commits

[arturo-aparicio]

Comment by kisunji Monday Jul 25, 2022 at 14:10 GMT

---

Confirming that the grpc call will default to DNS: https://github.com/grpc/grpc/blob/master/doc/naming.md#name-syntax=

Called here (ServerAddresses written to PeerServerAddresses written to ring buffer): https://github.com/hashicorp/consul/blob/927cee692b5743e4a309292e11e5238876f6bb76/agent/consul/leader_peering.go#L314=