search

opensource-spraakherkenning-nl / asr_nl

Dutch Speech Recognition webservice
https://webservices.cls.ru.nl/asr_nl
GNU Affero General Public License v3.0
6 stars 5 forks source link

wrapper script does not produce proper exit error code if an error occurs #2

Closed proycon closed 4 years ago

proycon commented 5 years ago

The wrapper script does not exit with an error code (i.e. non-zero) if an error occurs, that way CLAM is unaware something went wrong and can't convey it to the user, who may be surprised to find empty output whilst not getting a proper error.

proycon commented 5 years ago

I see there is not much of error handling at all in kaldi_recog.sh, whilst there are a lot of steps that could potentially go wrong. I'd like to suggest implementing some error catching (writing to stderr and returning proper error codes). That might make the debugging process easier, as I'm currently still clueless why and where the ASR engine fails.