Documentation bug - file format - Githubissues

opensource21 / jpencconverter

Converts with Java-Passwordbased encrypted files. It's a miror of https://gitlab.com/opensource21/jpencconverter so look there for the current version

Apache License 2.0

2 stars 1 forks source link

Documentation bug - file format #5

Open clach04 opened 1 week ago

clach04 commented 1 week ago

I got a bit lost and could not decrypt when attempting to follow the documentation comments:

https://github.com/opensource21/jpencconverter/blob/f65b630ea190e597ff138d9c1ffa9409bb4d56f7/src/main/java/de/stanetz/jpencconverter/cryption/JavaPasswordbasedCryption.java#L22

Based on https://github.com/opensource21/jpencconverter/blob/f65b630ea190e597ff138d9c1ffa9409bb4d56f7/src/main/java/de/stanetz/jpencconverter/cryption/JavaPasswordbasedCryption.java#L166

The nonce is before the salt. I.e.:

File format:

4 bytes - define the version.
nonce bytes - bytes as nonce for cipher depends. The length depends on the version.
salt bytes - bytes to salt the password. The length depends on the version.
content bytes - the encrypted content-bytes.

Are you OK with pull requests here? I have one open already, I am not sure if you have seen it yet or would prefer to post to https://gitlab.com/opensource21/jpencconverter

clach04 commented 1 week ago

Thanks again for this library and your help. My Python library is now ready 😀 , if there is anything you want to copy/paste from the readme feel free to grab it.