opensourceBIM / BIMserver

The open source BIMserver platform
GNU Affero General Public License v3.0
1.56k stars 611 forks source link

Render engine plugin settings missing in the geometry report #1323

Closed hlg closed 2 months ago

hlg commented 3 months ago

Currently, the geometry creation report does not display all render engine settings. For example opensourceBIM/IfcOpenShell-BIMserver-plugin commit cc68637 introduced a new setting. We want to see a list of all render engine settings in the report. This can be achieved by iterating over renderEngine.getSettings().getParameters() and adding the name and value of each parameter to the report, around here: https://github.com/opensourceBIM/BIMserver/blob/0ee3d93fae5c7a7470c8d1fbae7da46e9e07dd72/BimServer/src/org/bimserver/geometry/StreamingGeometryGenerator.java#L241-L254

Some more information for later reference: Contrary to the render engine attributes applyLayerSets and calculateQuantities, the new attribute is not used in the GeometryRunner and StreamingGeometryGenerator, and thus not necessary to keep it as a property of the any render engine implementation. The keeping of calculateQuantities as a render engine property might also deserve a review and refactoring.