search

opensourceBIM / BIMserver

The open source BIMserver platform
GNU Affero General Public License v3.0
1.56k stars 610 forks source link

Missing object parts. #506

Closed Jo64 closed 7 years ago

Jo64 commented 7 years ago

Hi Ruben, I have an IFC file in which some objects are not displayed completely. Please look at the attached picture. I've reduced the attached ifc file to the wrong objects. Can you please check this? Thanks.

Regards, Jo Chairs.zip bugchairs

webdada commented 7 years ago

I have also noticed missing IFC object parts, or IFC objects before. Not just this version.

rubendel commented 7 years ago

Looks real familiar with https://github.com/opensourceBIM/BIMserver/issues/495. Just started a new build for bimsurfer V1 (0.0.37), pretty sure that will fix this issue.

Jo64 commented 7 years ago

Well, that's what I thought, too, but it isn't. In #495 it was an object geometry with parts (geometryType == 3). The type of the single chair is an IfcFurnishingElement and it is evaluated as geometryType == 1. So the fixes from #495 don't solve the problem.

rubendel commented 7 years ago

Had another look at this, apparently IfcClosedShells were not included when generating geometry, and those were used for the upper parts of the furniture.

https://github.com/opensourceBIM/BIMserver/commit/215f78e369b9852461a9c79cb260c607ad2be04a

Jo64 commented 7 years ago

Ruben - Thank you for the changes chairs in BIMserver 1.5.73. This solves the geometry problems.