search

opensourceBIM / ClashDetectionService

A BIMserver plugin that does basic clash detection
4 stars 6 forks source link

Clash detection #3

Open tchegito opened 5 years ago

tchegito commented 5 years ago

I've seen that clash detection has been separated in another repository ( https://github.com/opensourceBIM/ClashDetectionService ) and is stated as "non working". But there's still code about that, and this happened to work before.

My question is: as a contributor, what problems might I encounter to make it working ? Has it been abandoned because of performance issues, or lack of time ? I think it's a really interesting feature.

tchegito commented 5 years ago

Actually, I'm trying to get it working, starting on the unit test.

It involves several things:

This is not finished yet, but I hope the whole process isn't broken ;)

rubendel commented 5 years ago

It's abandoned because we don't need it in any of our projects at the moment. I think you are going in the right direction for getting the code to work, should not be too hard.

What you might encounter is that the clash detection currently is very basic. For example all clash detection is done on the triangles (eventually), so round holes with round fillings probably will result in clashes even if the original (IFC) geometry says it should fit.

Performance is probably going to be ok, but there is also a lot of room to optimize if needed.

tchegito commented 5 years ago

Just added the pull request here: https://github.com/opensourceBIM/ClashDetectionService/pull/4

Changes in this repository + 2 other ones (PluginBase and BIMServer itself) inlined in the request.

I don't have produced any clashes in my tests (lacking a 'corrupt' model) but no exceptions anymore.

salamat-RGP commented 3 years ago

Hi!

Could you please clarify whether that project is still alive since it is marked as non-working?

Thank you in advance