This pull request uncomments the unit test, and make it working. It doesn't find any clashes in the standard IFC model but at least, it doesn't throw exceptions anymore.
Several notes:
unsure about 'shouldCheck'method where I disallow object with same OID. It seems to be the right
thing for me but I haven't any clashes at the end. A 'corrupt' IFC is lacking, which would have expected clashes
as repositories are fragmented inside opensourceBIM's constellation, I just drop the changes in other repo here as patches.
add the original IFC file in a new test resource folder to replace hardcoded filename
(minor one): don't really see the point to use different folders than Maven convention proposes. Using just 'src/main/java' and 'src/main/resources' (same remark for test) would simplify the POM and wouldn't need to add any 'helper-plugin' to attach additional files.
Changes in BIMServer:
just add 'if false' inside org.bimserver.webservices.authorization.ExplicitRightsAuthorization class:
public void canWriteExtendedData(long roid) throws UserException {
if (false && getWriteExtendedDataRoid() != roid) {
throw new UserException("No rights to write extended data to revision");
}
}
not sure about that one, but it was necessary to check that clash detection was triggered when a new revision was pushed
Changes in PluginBase (to rehabilitate OfflineGeometry
This pull request uncomments the unit test, and make it working. It doesn't find any clashes in the standard IFC model but at least, it doesn't throw exceptions anymore.
Several notes:
Changes in BIMServer:
Changes in PluginBase (to rehabilitate OfflineGeometry
PluginBase_offlineGeometry_patch.txt