Firefox will (probably) not be able to log in at next release

opensourceBIM / bimvie.ws

Javascript client for Building Information Modelling, using open standards like IFC, BCF and BIMSie. Using Bootstrap, BIM Surfer, etc..

GNU Affero General Public License v3.0

173 stars 87 forks source link

Firefox will (probably) not be able to log in at next release #111

Open sigurdne opened 6 years ago

sigurdne commented 6 years ago

Made an attempt at Version: 1.5.103-SNAPSHOT in eclipse: This commit on Jun 12 seems to break the index/login-page when using Firefox https://github.com/opensourceBIM/bimvie.ws/commit/9a0fb16d43690c774c8980b8da9beae42ee751aa

Firefox version 61.0.1

Regards

sigurdne commented 6 years ago

I am struggling with finding the exact code change that caused Firefox to complain. I followed the instructions for eclipse https://github.com/opensourceBIM/BIMserver/wiki/Eclipse And rolled back changes to may 2018 for:

bimvie.ws
BIMserver-JavaScript-API
BIMserver

But still Firefox is complaining as follows:

SyntaxError: import declarations may only appear at top level of a module

Regards

rubendel commented 6 years ago

At the moment we only develop/test on Google Chrome. So that's also the only platform supported. Any fixes that make BIMvie.ws work on other platforms are always welcome.

The problem here is that we don't know in advance where the API is coming from (it's dynamic), but Firefox does not like this, I think they will change this in the future as this is not a unique problem. Also when dynamic loading of modules has been standardized, we can switch to that.