search

opensourceBIM / bimvie.ws

Javascript client for Building Information Modelling, using open standards like IFC, BCF and BIMSie. Using Bootstrap, BIM Surfer, etc..
GNU Affero General Public License v3.0
170 stars 85 forks source link

fix module import with relative path #123

Closed hlg closed 5 years ago

hlg commented 5 years ago

https://github.com/opensourceBIM/BIMserver/issues/882#issuecomment-457918418

The modules were still resolved from root due to the base path setting. I can't see how the base path set to root would be needed for something else, but am not 100% sure (LazyLoad?). I tested with BIMserver both exposed on domain root and non-root setup and both seem to work fine.

hlg commented 5 years ago

Ok, previously it was possible to omit the trailing slash in <context>/apps/bimviews/ which is now broken. So if that is required behaviour, this needs a little more thought. However, since this just short for <context>/apps/bimviews/index.html, I don't think this should be a case.

hlg commented 5 years ago

This is obsolete now.

rubendel commented 5 years ago

Sorry about that, I am still trying to get this to work OK, almost there I think

hlg commented 5 years ago

No worries. I saw that you are working on it and that it seems to be more involved than this.