search

opensourceautomation / Open-Source-Automation

Open Source Automation is a home and commercial automation engine
www.opensourceautomation.com
GNU Lesser General Public License v3.0
97 stars 62 forks source link

Alias enhancements #320

Closed VaughnRupp closed 8 years ago

VaughnRupp commented 8 years ago

Now that Alias is in place, the script processor needs to be updated to allow them to be used as the object name.

Also, when parsing output placeholders, if an object has an alias, it should be used in the output. So when I ask "Who are you?" I don't get SYSTEM or my full name, the more friendly alias who be used.

VaughnRupp commented 8 years ago

All the places I am seeing this as an issue is not using output parsing, so it can't be fixed in Pattern_Parse. I think the issue will have to be addressed in the Grammar recognition, during pronoun replacements, and parameter validation. I will look at that next.

VaughnRupp commented 8 years ago

Well, at this time, it cannot be done at the api level, it is a gUser issues that is passing the name to everything. I modified Jabber and VR to load the alias into the gUser variable (if there is an alias). This will test the trust system and fromobject code to make sure it works with the alias and not just an object name, so this will be fun in testing.

Still going to add alias support to scripting now.

VaughnRupp commented 8 years ago

GetObjectByName accepts Alias, so the scripting notation of Object.Name = is all that is needed, Object.Alias is redundant, so no changes to script processor need to be made.

That was the last issue on this ticket, I am closing it until testing cycle.