opensourceautomation / Open-Source-Automation

Open Source Automation is a home and commercial automation engine
www.opensourceautomation.com
GNU Lesser General Public License v3.0
97 stars 62 forks source link

Grammar Parameters #321

Open VaughnRupp opened 8 years ago

VaughnRupp commented 8 years ago

Make sure grammar support parameters for Method calls.

It is not good enough to be able to say Kitchen Lights ON we must support: Kitchen Light ON 50

(50 representing level in an Insteon light in that example)

VaughnRupp commented 8 years ago

Actually, entire method support is missing.

[OBJECT] is [STATE] is just to set the state and should not accept parameters.

[OBJECT] [METHOD] is a separate pattern that looks to have gotten lost. I will recreate it, and the grammar code and accept parameters on it.

VaughnRupp commented 8 years ago

Scripting only supports 2 parameters. Object & Method eat those up, so this 3rd parameter needs to be merged into the 2 or more parameter support needs to be added.

The impact of Grammar and parameters has only been tested with OSA's script processor and PowerShell needs to be added to testing and support, that is for another ticket though, after I figure it out here.