search

opensourcecities / montreal

A directory of companies, people, and projects that are Open Source and from Montréal.
https://opensourcecities.github.io/montreal/
The Unlicense
98 stars 31 forks source link

WIP: Enhance travis #56

Closed khos2ow closed 6 years ago

RichardLitt commented 6 years ago

What does the dangerfile do?

khos2ow commented 6 years ago

It seems you can check/validate the "conventions" you want to set. In this particular case there's an integration between awesome_bot and Danger to report back errors to the PR.

Since we're going to allow 302 status, I thought it would be a good idea to have a visibility of them, because there might be some cases which 302 wouldn't be acceptable.

RichardLitt commented 6 years ago

Cool. Given the amount of PRs we get, though, is this really a necessary addition? I think the added complexity might make it more brittle, not less, especially as adding a link to a whitelist is trivial.

khos2ow commented 6 years ago

Once setup, there won't be any additional complexity, on the other hand I think it will kinda simplify the process. If Travis fails it pushes back a comment to the PR as this which we can immediately see what's going on.

RichardLitt commented 6 years ago

Alright then!

khos2ow commented 6 years ago

NO, it wasn't complete yet!! Reverted the merge.

RichardLitt commented 6 years ago

Ah!

Can you start naming your PRs which aren't complete as WIP? Otherwise, I'll assume it is ready to merge; otherwise, the act of a PR itself signals that it is done.

khos2ow commented 6 years ago

The name of this PR still contains WIP :wink: and btw I added a label too work-in-progress