opensourcecobol / opensourcecobol4j

A new version of opensourcecobol. Translate COBOL to Java.
https://opensourcecobol.github.io/opensourcecobol4j/
GNU General Public License v3.0
74 stars 34 forks source link

Add devcontainer #529

Closed yutaro-sakamoto closed 2 weeks ago

yutaro-sakamoto commented 3 weeks ago

This pull request introduces a variety of changes to the development environment setup, static analysis workflow, and code formatting for the OpenSource COBOL 4J project. The most important changes include setting up a new development container, updating the static analysis workflow to use almalinux, and switching from Google Java Format to Spotless for code formatting.

Development Environment Setup:

Static Analysis Workflow:

Code Formatting:

Code Cleanup:

Format C files and Java files with new formatter in the Devcontainer

clang-format and a new formatter spotless formated all C files and Java files in the development environment.

yutaro-sakamoto commented 3 weeks ago

@tsh-hashimoto @kio-watanabe Please read CONTRIBUTING.md or CONTRIBUTING_JP.md and create a new development environment. This is the highest priority task related to opensource COBOL 4J.

As explained in CONTRIBUTING.md, I suggest that we use Dev Containers of Visual Studio Code as a standard development environment. If you success to create a new development environment and find no issue, please aprove reviews I requested. Otherwise, please give me your questions and suggestions.

tsh-hashimoto commented 2 weeks ago

Just in case...

  1. Clone the repository

Is it alright to clone the repository yutaro-sakamoto:add-devcontainer? (It may a temporary concern. Once your changes are merged, It will not to be necessary to worry about)

yutaro-sakamoto commented 2 weeks ago

@tsh-hashimoto Yes, you can clone yutaro-sakamoto:add-devcontainer.

Prepare an opensource COBOL 4J repository with the contents of the yutaro-sakamoto:add-devcontainer branch, either by git clone or git checkout.

tsh-hashimoto commented 2 weeks ago

Thanks. It seemed to be able to set up the Docker environment. スクリーンショット 2024-10-28 111051

I'll approve this PR.

yutaro-sakamoto commented 2 weeks ago

@kio-watanabe I have merged this pull request because @tsh-hashimoto verified that the new development environment worked. Please try to create the new development environment on your machine.