search

opensourcedesign / opensourcedesign.github.io

🎨💻 Source code of our website
https://opensourcedesign.net
Apache License 2.0
354 stars 188 forks source link

Git ignored cname so it won’t change unless we need it to #213

Closed RDIL closed 5 years ago

jancborchardt commented 5 years ago

What’s the specific reason for adding it to the ignore list? It never gets edited manually anyway, and was added initially through enabling the domain connection in the Github repo settings. I don’t think it’s necessary to put it on the ignore list?

RDIL commented 5 years ago

Just to 100% make sure it stays static.

On Thu, Jan 10, 2019 at 4:30 PM Jan-Christoph Borchardt < notifications@github.com> wrote:

What’s the specific reason for adding it to the ignore list? It never gets edited manually anyway, and was added initially through enabling the domain connection in the Github repo settings. I don’t think it’s necessary to put it on the ignore list?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opensourcedesign/opensourcedesign.github.io/pull/213#issuecomment-453261310, or mute the thread https://github.com/notifications/unsubscribe-auth/Ag9GdnLC1CT7L3x6Z35LJcsklX4VUvDiks5vB7EKgaJpZM4Z5de- .

jancborchardt commented 5 years ago

Seems it also helps with build issues on forks, so I guess it’s fine to add: https://github.com/trek/beautiful-open/issues/43