opensourcedesign / opensourcedesign.github.io

🎨💻 Source code of our website
https://opensourcedesign.net
Apache License 2.0
347 stars 187 forks source link

[Work in progress] Add affiliation part to front page #215

Closed jancborchardt closed 5 years ago

jancborchardt commented 5 years ago

Added the logos as a starting step for Missing Affiliation page on the website #168 :) (They are already minified via scour.)

@aaqaishtyaq we should put them on the frontpage on the bottom so they are present, but not in the footer so they are not on all pages. Sounds good?

Also we should link the logos to their websites, what do you think @opensourcedesign/website

jancborchardt commented 5 years ago

And just to specifiy @RDIL cause you added the tag to the issue: This would not be a new page, but on the bottom of the front page.

We should not create new pages, but we are rather about to reduce the pages, as specified in the website discussion at https://discourse.opensourcedesign.net/t/open-source-design-website-review/773 :slightly_smiling_face:

RDIL commented 5 years ago

Ah okay

jancborchardt commented 5 years ago

@AnXh3L0 this is the pull request with the assets. :)

The code for the Open Collective embed seems to be this:

// Not sure if this JS file is needed?
<script src="https://opencollective.com/opensourcedesign/banner.js"></script>

// Sponsors
<object type="image/svg+xml" data="https://opencollective.com/opensourcedesign/tiers/sponsor.svg?avatarHeight=36&width=600"></object>

// Backers
<object type="image/svg+xml" data="https://opencollective.com/opensourcedesign/tiers/backer.svg?avatarHeight=36&width=600"></object>

// One-time sponsor
<object type="image/svg+xml" data="https://opencollective.com/opensourcedesign/tiers/one-time-sponsor.svg?avatarHeight=36&width=600"></object>
AnXh3L0 commented 5 years ago

At the moment, I have added two new sections for Supporters and Affiliates, need some ideas/thoughts on how to improve it visually.

image

evalica commented 5 years ago

We could also separate the OpenCollective backers in a different category. So that would mean 3 categories: Affiliates, Supporters and Backers.

Also I would have the Affiliates at the top, since they are well known, plus fewer than the Backers, that the list could increase.

jancborchardt commented 5 years ago

@AnXh3L0 the only feedback to improve it visually is to increase the whitespace above the Open Collective row a bit, as well as the whitespace above the "Affiliates" text. Then it looks great! :)

@evalica I actually would say the sorting is good:

elioqoshi commented 5 years ago

Since this is approved, let's go ahead and merge this. We can revisit the sorting in the new website redesign: https://github.com/opensourcedesign/opensourcedesign.github.io/issues/242

AnXh3L0 commented 5 years ago

@elioqoshi the changes I made weren't in this branch yet, that's why they aren't online.

elioqoshi commented 5 years ago

Ah okay sorry I was not aware. Ping us when they are

jancborchardt commented 5 years ago

@AnXh3L0 can you do a pull request with your changes then? I can do the additional adjustments too. :)

AnXh3L0 commented 5 years ago

Yes, I can do a PR by the end of this week.

jancborchardt commented 5 years ago

@AnXh3L0 when you do a PR, I just remembered we should also add the Open Source Initiative to the affiliates! :) This would be the page to link to: https://opensource.org/affiliates