search

opensourcedesign / opensourcedesign.github.io

🎨💻 Source code of our website
https://opensourcedesign.net
Apache License 2.0
347 stars 186 forks source link

Style: Run prettier #281

Closed RDIL closed 4 years ago

RDIL commented 4 years ago

Reformats the code with Prettier, which makes code feel the same across the site. Note: HTML files with front matter did not get reformatted due to parsing errors.

jancborchardt commented 4 years ago

While I’m generally not a fan of automated changes like this for the possible breakage they can induce, I agree with the changes and it seems fine – except for the small comments. :)

Also a note that this removes the "Activity" section from the frontpage which used to show some Github activity from the organization. As that is not the main focus of Open Source Design and it actually did not work since some time anyway, it’s fine to remove this.

Good stuff as usual @RDIL! :)

RDIL commented 4 years ago

Fixed everything @jancborchardt :)

RDIL commented 4 years ago

Hey @jancborchardt while you are online, I fixed all the issues here.

jancborchardt commented 4 years ago

Hey @jancborchardt while you are online, I fixed all the issues here.

Looks good! Only shows a conflict in _layouts/jobs.html

RDIL commented 4 years ago

@Yashank18 can you approve once more so we can merge? 😄

Yashank18 commented 4 years ago

Ready to merge :)