Closed GarthDB closed 9 years ago
This is the only thing that is causing tests to fail currently.
@GarthDB Really, the files are there, but there is a wrong reference to the file, I guess.
The notes file is there, that's where the reference to the missing file is, it's missing the marked.js file.
— Sent from Mailbox
On Sun, Nov 22, 2015 at 12:18 AM, Raghu Ranganathan notifications@github.com wrote:
@GarthDB Really, the files are there, but there is a wrong reference to the file, I guess.
Reply to this email directly or view it on GitHub: https://github.com/opensourcedesign/opensourcedesign.github.io/issues/36#issuecomment-158734348
So, where did marked.js go?
On Nov 22 2015, at 12:51 pm, Garth Braithwaite <notifications@github.com> wrote:
The notes file is there, that's where the reference to the missing file is, it's missing the marked.js file.
—
Sent from Mailbox
On Sun, Nov 22, 2015 at 12:18 AM, Raghu Ranganathan
<notifications@github.com> wrote:
> @GarthDB Really, the files are there, but there is a wrong reference to
the file, I guess.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/opensourcedesign/opensourcedesign.github.io/issues/36#
issuecomment-158734348
—
Reply to this email directly or view it on GitHub.
No idea, that's why I filed the issue instead of making a pull request with the fix. I don't know the story here and was hoping someone else did.
If it was deleted by accident let's get it back, or else we should delete notes.html
You can take look at https://github.com/opensourcedesign/opensourcedesign.github.io/tree/master/slideshows/free-and-usable#full-setup or just copy the folder markdown at https://github.com/hakimel/reveal.js/tree/master/plugin and done
I think the notes here are just a remnant of pulling the non-compiled reveal.js files into the repo, something that should probably have been avoided but is not really a big deal.
@jancborchardt looks like you originally committed this, can you confirm?
Removing notes.html
from the directory doesn't break the actual slideshow, so we can just remove it (if something bad happens, it's okay, we were using version control!)
It looks like the notes plugin page is requiring a js file that doesn't exist.