search

opensourcedesign / opensourcedesign.github.io

🎨💻 Source code of our website
https://opensourcedesign.net
Apache License 2.0
357 stars 188 forks source link

Header on the Jobs page is different from other pages #435

Open nevfy-y opened 9 months ago

nevfy-y commented 9 months ago

This doesn't seem intentional. I think the header should have remained the same on every page.

Goals page: 2024_02_02_02_27_AM

Jobs page: 2024_02_02_02_28_AM

Erioldoesdesign commented 7 months ago

hey there @nevfy-y i don't think it's intentional - I think the main reason the jobs page header navigation doesn't get updated to match the 'rest' of the website is just because the page/index code 'on(?)' a different repo: https://github.com/opensourcedesign/jobs/blob/master/index.html

Erioldoesdesign commented 7 months ago

If you'd like to open a pull request to fix this please go ahead - I think it'd be good for the nav header to match across the website 😄

subz3r0o0 commented 7 months ago

hi could i be assigned to fix this issue, thank you!

Erioldoesdesign commented 7 months ago

hi could i be assigned to fix this issue, thank you!

Feel free to submit a PR - I'll assign you to this issue for 2 weeks and then check back in and un-assign if I do not see any comments or PR's :)

subz3r0o0 commented 7 months ago

great, thank you. is the issue mostly that the title is not aligned in the centre correctly across the job page

Erioldoesdesign commented 7 months ago

great, thank you. is the issue mostly that the title is not aligned in the centre correctly across the job page

It is also that the navigation menu, if you look at the two screenshots is different, because the job's page has it's own index html in another repo on our account :)

subz3r0o0 commented 7 months ago

Hi there, I am currently working on this issue. I am slightly confused about how the subrepos link to the main repository. Thanks.

Erioldoesdesign commented 7 months ago

Hi there, I am currently working on this issue. I am slightly confused about how the subrepos link to the main repository. Thanks.

I'm not sure I can give you much advice here other than you may need to 'pull' each repo separately and basically mimic/copy code across. I don't know if @AnXh3L0 or @SaptakS has better advice

subz3r0o0 commented 7 months ago

Should i message them? :)

Erioldoesdesign commented 7 months ago

Should i message them? :)

Go for it :)

subz3r0o0 commented 7 months ago

Hi there @AnXh3L0 and @SaptakS, I am currently working on this issue. I am confused about how the subrepos link to the main repository. Thanks.

Erioldoesdesign commented 6 months ago

Hi there @AnXh3L0 and @SaptakS, I am currently working on this issue. I am confused about how the subrepos link to the main repository. Thanks.

You might find they are quite busy but don't be afraid to ping them again in around 4-5 days they'll let you know if they are too busy to support :)

subz3r0o0 commented 6 months ago

Hi there @AnXh3L0 and @SaptakS, please let me know if you know if you see this message.

Erioldoesdesign commented 5 months ago

It seems @AnXh3L0 and @SaptakS are busy so maybe @elioqoshi or @jancborchardt might be able to help? or perhaps know anyone else that can help out

jancborchardt commented 5 months ago

@subz3r0o0 on the readme in the main repository, step 3 in the installation setup is to clone the jobs repo: https://github.com/opensourcedesign/opensourcedesign.github.io

The jobs repo has to be cloned into the opensourcedesign.github.io repo as per the documentation, then it should work?

If something is unclear or not working, we need to amend it. :)